Thrust / Speed issue, Combat Cloak

[Hammerburg]

Hi,

 

when i switch to combat cloak and push the rmb, sometimes the thrust goes straight to max speed and stays on max speed. The same happens when i use the thrust keys or buttons (backward also).

 

Devices with speed: Nitrous Oxide System, Coma 9

Engine: Pegasus 5

[Zackman [LDEV]]

I was able to reproduce it. It happens when the ship is accelerating, so either you have the "thrust lock" engaged

or the forward-thrust key pressed down in the very moment any of your stats/buffs are changing.

 

This is due to the latest changes updating the max speed while thrusting forward (eg. NOS, speed buffs etc).

 

To fix this here, we have to sacrefice something tho, since a client limitation is kicking in.

 

The code for changing your max speed when applying buffs (or devices like NOS) will only change your speed if you are 

already at max speed.

 

So when you are accelerating but dont have max speed reached yet, any applied speed buff will not automatically

change your speed to the new max speed - you need to re-engage "the gas pedal" to have the buff kicking in.

 

If you already at the "old" max speed and a speed buff kicks in, then the new max speed gets applied right away

without the need to "re-pedal".

 

So basically any speed buff is updated while at max speed but not if you are currently accelerating BELOW max speed.

The old rule, that speed buffs are always applied while standing still are still valid.

 

Sume up of how speed buffs get applied after this fix:

1. Ship is standing still

2. Ship is thrusting forward (or backward) at the max speed the very moment speed buff kicks in

3. Release and re-engage thrust right after speed buff was applied

 

 

This is the golden middle of speed buffs getting applied without jumping you unintended to max speed.